Pages Editor: add "Delete Task from Page" functionality #7075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goplayoutside3
approved these changes
Apr 22, 2024
|
|
||
| // Cleanup, then commit. | ||
| const cleanedTasksAndSteps = cleanupTasksAndSteps(newTasks, newSteps); | ||
| update(cleanedTasksAndSteps); |
There was a problem hiding this comment.
Nice! I like how the code comments in this function are easy to read through 👍
Comment on lines
11
to
+25
| export default function cleanupTasksAndSteps(tasks = {}, steps = []) { | ||
| const newTasks = structuredClone(tasks); // Copy tasks | ||
| let newSteps = steps.slice(); // Copy steps | ||
| let newSteps = structuredClone(steps); // Copy steps. This is a deep copy, compared to steps.slice() | ||
|
|
||
| // Remove steps without tasks. | ||
| newSteps = newSteps.filter(step => step?.[1]?.taskKeys?.length > 0); | ||
|
|
||
| // Remove tasks not associated with any step. | ||
| Object.keys(newTasks).forEach(taskKey => { | ||
| let existsInAnyStep = false; | ||
| newSteps.forEach(step => { | ||
| existsInAnyStep = existsInAnyStep || !!step?.[1]?.taskKeys?.includes(taskKey); | ||
| }); | ||
| if (!existsInAnyStep) delete newTasks[taskKey]; | ||
| }); |
There was a problem hiding this comment.
Just linking this FEM Issue about orphaned tasks for documentation. Your implementation here means any project using the Pages Editor solves the bug 🎉 Hopefully all FEM projects soon 🤞
shaunanoordin
force-pushed
the
pages-editor-pt19
branch
from
ae9d5d1 to
f3db498
Compare
…sksAndSteps: fix order of actions.
shaunanoordin
force-pushed
the
pages-editor-pt19
branch
from
f3db498 to
22dcb15
Compare
|
Thanks Delilah! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Part of: Pages Editor MVP project and FEM Lab super-project
Follows #7065
Staging branch URL: https://pr-7075.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging
This PR implements the "Delete Task" functionality, which deletes Tasks from an existing Page. Prior to this PR, you only had the "Delete Page/Step" functionality.
New Behaviour:
cleanupTasksAndSteps()now properly removes Steps/Pages that have 0 Tasks, and removes Tasks that aren't associated with any Page/Step.Testing Steps
Status
Ready for review!